Skip to content

Fix admin user edit link for custom user classes #6508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minhluuquang wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Fix admin user edit link for custom user classes #6508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/app/views/spree/admin/users/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
<td class="align-center"><%= l user.created_at.to_date %></td>
<td data-hook="admin_users_index_row_actions" class="actions">
<% if can?(:edit, user) %>
<%= link_to_edit user, no_text: true, url: spree.admin_user_path(user) %>
<%= link_to_edit user, no_text: true, url: spree.edit_admin_user_path(user) %>
<% end %>
<% if can?(:destroy, user) && user.can_be_deleted? %>
<%= link_to_delete user, no_text: true, url: spree.admin_user_path(user) %>
Expand Down
5 changes: 4 additions & 1 deletion backend/spec/controllers/spree/admin/users_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
end)
@actual_user_class_name = Spree.user_class.name
Spree.user_class = "UserModel"
UserModel.create(email: "a@solidus.io")
@custom_user = UserModel.create(email: "a@solidus.io")

@jarednorman jarednorman Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this instance variable?

allow(Spree.user_class).to receive(:find_by)
.with(hash_including(:spree_api_key))
.and_return(Spree.user_class.new)
Expand All @@ -88,6 +88,9 @@
get :index

expect(response).to be_successful

edit_link = Nokogiri::HTML(response.body).at_css("a.icon_link[data-action='edit']")
expect(edit_link["href"]).to eq spree.edit_admin_user_path(@custom_user)
end
end
end
Expand Down
Loading