[tests] Add tests for skip/enable-plugins merge from config and cmdline#4358
Open
jcastill wants to merge 1 commit into
Open
[tests] Add tests for skip/enable-plugins merge from config and cmdline#4358jcastill wants to merge 1 commit into
jcastill wants to merge 1 commit into
Conversation
Member
Author
|
Some quick notes and questions:
|
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Member
I agree, let's clean up the comments, at least that's my opinion
I don't have an opinion on that, as long as we're testing
Naming is cool with me
I think that would make sense, then it covers all the options |
Verify that skip-plugins and enable-plugins are merged (not replaced) when specified in both sos.conf and command line. Also verify that the option only-plugins uses replacement (not merge) approach, and that preset options take precedence over config file values. This is a regression test for commit 8fc655a, which fixed the merge behavior. The new tests verify both effective options logging in sos.log and actual plugin execution. Signed-off-by: Jose Castillo <jcastillo@redhat.com>
5a33840 to
15d138a
Compare
Member
Author
|
I've added some extra tests to cover more use cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify that skip-plugins and enable-plugins are merged (not replaced)
when specified in both sos.conf and command line.
This is a regression test for commit 8fc655a, which fixed the merge
behavior. The new tests verify both effective options
logging in sos.log and actual plugin execution.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines