Compatibility with sf 8 + behat 4 + mink 3 - #42
Open
julien-maurel wants to merge 1 commit into
Open
Conversation
Jean-Beru
reviewed
Jul 29, 2026
Jean-Beru
left a comment
Jean-Beru
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your contribution @julien-maurel. Just 2 comments about BC promise.
| "php": ">=8.0", | ||
| "behat/behat": "^3.0.13", | ||
| "friends-of-behat/mink-extension": "^2.3.1", | ||
| "behat/behat": "^4.0", |
Collaborator
There was a problem hiding this comment.
It's clearly a BC break. This extension couldn't be used with Behat 3.
| trait Html | ||
| { | ||
| abstract protected function getSession($name = null); | ||
| abstract public function getSession(?string $name = null): Session; |
Collaborator
There was a problem hiding this comment.
public function getSession($name = null) should be used to keep compatibility with Mink v2 and v3
Author
@Jean-Beru Yes, I didn't try to keep compatibility with current major versions and incomming ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We just migrate ours apps to symfony 8 and behat 4, so we do changes about that.
It can be merged as it but I think it might be worth spending a bit more time to have more type hinting.
What do you think ?