Fix DataRecord serialization#6619
Open
ElectroJr wants to merge 1 commit into
Open
Conversation
ElectroJr
commented
Jun 6, 2026
Comment on lines
-107
to
114
| if (type.IsValueType) | ||
| if (isRecord) | ||
| { | ||
| CreateValueTypeInstantiator(generator, type); | ||
| CreateRecordInstantiator(generator, type); | ||
| } | ||
| else if (isRecord) | ||
| else if (type.IsValueType) | ||
| { | ||
| CreateRecordInstantiator(generator, type); | ||
| CreateValueTypeInstantiator(generator, type); | ||
| } |
Member
Author
There was a problem hiding this comment.
Switching these if blocks is what actually fixes #6556. Without this, the constructors of DataRecord structs are basically just ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataRecord serialization is pretty broken at the moment. Default values are ignored for structs (see #6556) and simple records using floats or negative default values will cause
SerializationManager.CreateRecordInstantiator()to generate invalid IL. E.g., neither of these work:I've tried to fix both of these issues, and added a bunch more tests, but I'm not super confident that I've got all the edge cases and the code is somewhat convoluted. I'm also not that confident in writing IL code, and mostly worked backwards by looking at actual IL that got generated when manually calling record constructors.
Fixes #6556