Fixes for engine SpawnNextToOrDrop changes#44204
Open
SnappingOpossum wants to merge 2 commits into
Open
Conversation
SnappingOpossum
requested review from
Princess-Cheeseballs and
sowelipililimute
as code owners
PJBot
added
S: Untriaged
themias
added
P2: Raised
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Made for space-wizards/RobustToolbox#6605, shouldn't break anything even without it.
Why / Balance
Engine change would break stuff without this.
Technical details
Made Metamorf not DropNextTo after the SpawnNextToOrDrop, which led to removing the SharedTransformSystem dependency, and removed an unused out var. Rest is really simple stuff.
Test plan
Make an item from a chemical reaction (like soap).
Butcher something with a meat spike.
Make a burger.
Media
Requirements
Breaking changes
Changelog