Skip to content

fix(config): validate volume mount paths syntactically instead of filepath - #1

Closed
spapa013 wants to merge 1 commit into
spapadop/plt-859-stabilize-devenv-startup-script-so-generated-devenvs-bootfrom
spapadop/plt-881-volumemount-path-validation-incorrectly-uses-filepath
Closed

fix(config): validate volume mount paths syntactically instead of filepath#1
spapa013 wants to merge 1 commit into
spapadop/plt-859-stabilize-devenv-startup-script-so-generated-devenvs-bootfrom
spapadop/plt-881-volumemount-path-validation-incorrectly-uses-filepath

Conversation

@spapa013

@spapa013 spapa013 commented Mar 5, 2026

Copy link
Copy Markdown
Owner

Stacked on nauticalab#24

Summary

  • replace filepath validation on VolumeMount.localPath and VolumeMount.containerPath with mount_path
  • implement mount_path as syntax-only validation (absolute path shape), with no filesystem checks
  • add regression tests to verify:
    • /mnt is accepted
    • /mnt/data is accepted
    • empty mount paths are rejected

Problem

filepath validation is filesystem-dependent and file-oriented (os.Stat-based), so valid directory mount roots like /mnt were being rejected during devenv generate depending on runtime environment.

Validation

  • automated: go test -v -race -covermode=atomic -coverprofile=./coverage.out ./... (pass)
  • manual: generated config, SSH’d into pod, and confirmed /mnt mounted as expected

@spapa013 spapa013 closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant