Repository navigation
fix(workspace): move off the yanked chacha20 0.10.1 - #337
Merged
Merged
Conversation
`chacha20` 0.10.0 and 0.10.1 were yanked from crates.io. The SSE2 backend of the RNG and legacy 64-bit-counter variants used `_mm_extract_epi32`, an SSE4.1 intrinsic, so a CPU with SSE2 and without SSE4.1 met an illegal instruction instead of a working fallback. 0.10.2 replaces it with `_mm_storeu_si128`, which is SSE2 (RustCrypto/stream-ciphers#580). Nothing about ciphertext, keys or nonces changes. The fault is portability, and the affected path is reachable only on x86_64 hardware predating SSE4.1. `deny.toml` sets `yanked = "deny"`, so the yank fails `make deny` on every branch until the lockfile moves. The crate reaches the shipped tree through `apache-avro` and `async-nats`, both by way of `rand` 0.10.2. THIRD-PARTY.md carries the version, so it is regenerated here. Changelog: none
MarcusKainth
enabled auto-merge (squash)
August 27, 2026 22:18
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes, and why
chacha200.10.0 and 0.10.1 were yanked from crates.io, and 0.10.1 is what the lockfile pins.deny.tomlsetsyanked = "deny", somake denyfails on every branch until the lock moves. This bumps it to 0.10.2 and regeneratesTHIRD-PARTY.md, which carries the version.The yank is worth stating plainly, because two consecutive releases of a cryptographic primitive being pulled reads worse than it is. The SSE2 backend of the RNG and the legacy 64-bit-counter variants used
_mm_extract_epi32, an SSE4.1 intrinsic. A CPU with SSE2 and without SSE4.1 therefore met an illegal instruction rather than a working fallback. 0.10.2 replaces it with_mm_storeu_si128, which is SSE2 (RustCrypto/stream-ciphers#580).Nothing about ciphertext, key handling or nonce handling changes, on any hardware that ran at all. The fault is portability, and the affected path needs x86_64 hardware predating SSE4.1 to reach. Our own exposure was nil in practice: the aarch64 targets take the NEON backend, and any x86_64 CPU new enough to select the AVX2 backend never entered the SSE2 path.
The crate reaches the shipped tree transitively, through
apache-avroandasync-nats, both by way ofrand0.10.2. No first-party code calls it.Invariants
None.
Semver
A lockfile bump within a patch release of a transitive dependency. No public API moves.
Checks
make gateschangelog.d/, if this reaches a crate somebody upgrading would care aboutworkspaceis an exempt scope and the commit carriesChangelog: none. Nothing a user calls behaves differently, so there is nothing for a fragment to say.Anything else
make denyis the check that matters here, and it goes from failing on the yank toadvisories ok, bans ok, licenses ok, sources ok.THIRD-PARTY.mdis regenerated withmake attributionrather than edited, so it stays a function ofCargo.lock.#336 is blocked on this and should rebase once it lands.