Skip to content

fix: migrator recover from v2 nulls - #559

Merged
JR-Morgan merged 4 commits into
mainfrom
migrator-fixes
Oct 15, 2026
Merged

JR-Morgan merged 4 commits into
mainfrom
migrator-fixes

Conversation

@JR-Morgan

Copy link
Copy Markdown
Member

V2 has nulls everywhere

@JR-Morgan

Copy link
Copy Markdown
Member Author

This change isn't worth deploying on its own, it's v2 edge-cases only.

I'm leaving it parked here waiting for a more critical fix to justify updating the migrator.

@JR-Morgan JR-Morgan changed the title recover from v2 nulls fix: migrator recover from v2 nulls Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.58%. Comparing base (97666c5) to head (0e70826).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Sdk.BundleMigrator/Migration/PipelineExtensions.cs 10.52% 11 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   75.59%   75.58%   -0.02%     
==========================================
  Files         483      483              
  Lines       27020    27025       +5     
  Branches     2725     2730       +5     
==========================================
  Hits        20426    20426              
- Misses       5615     5618       +3     
- Partials      979      981       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JR-Morgan
JR-Morgan marked this pull request as draft August 28, 2026 09:20
@JR-Morgan
JR-Morgan marked this pull request as ready for review September 28, 2026 10:42
@JR-Morgan
JR-Morgan changed the base branch from big-truck to main September 29, 2026 11:58
@gitguardian

gitguardian Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
37689686 Triggered Generic High Entropy Secret ad362a6 garage.toml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Merging main brought in the plane-normalisation switch whose `Circle c`
arm collides with `geometry is Curve c` (CS0136).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@JR-Morgan
JR-Morgan enabled auto-merge (squash) October 9, 2026 11:33
@JR-Morgan
JR-Morgan disabled auto-merge October 15, 2026 14:10
@JR-Morgan
JR-Morgan merged commit 9947615 into main Oct 15, 2026
4 checks passed
@JR-Morgan
JR-Morgan deleted the migrator-fixes branch October 15, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant