Repository navigation
ci(integration): set the server's local-dev stand-in switch under both env names - #593
Open
gjedlicska wants to merge 1 commit into
Open
gjedlicska wants to merge 1 commit into
gjedlicska wants to merge 1 commit into
Conversation
…h env names The internal compose runs speckle-server:latest with the off-cluster Docker stand-in for viewer-.dat generation. The server's job-system boundary refactor (ENG-10149, on feat/job-system) renames the switch from CONVERSION_RUNNER_LOCAL_DEV to JOB_SYSTEM_LOCAL_DEV; `latest` will start reading the new name whenever that branch reaches main. Setting both keeps the suite green across the transition with no merge ordering between the repos. Drop CONVERSION_RUNNER_LOCAL_DEV once the rename is on a published `latest`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 75.71% 75.71% -0.01%
==========================================
Files 483 483
Lines 27028 27028
Branches 2724 2724
==========================================
- Hits 20464 20463 -1
Misses 5586 5586
- Partials 978 979 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JR-Morgan
approved these changes
Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
docker-compose-internal.ymlrunsspeckle-server:latestwith the off-cluster Docker stand-in for viewer-.datgeneration, switched on byCONVERSION_RUNNER_LOCAL_DEV. The server's job-system boundary refactor (ENG-10149, onfeat/job-system) renames that switch toJOB_SYSTEM_LOCAL_DEV. Once that branch reachesmain,latestreads the new name and.datgeneration in this suite would throwJobSystemNotInClusterError.What
Set the switch under both names. Today's
latestreads the old one, the post-rename image reads the new one; either way the stand-in is on. No merge ordering needed between the two repos.Follow-up
Drop
CONVERSION_RUNNER_LOCAL_DEVonce the rename is on a publishedlatest.Verification
DOCKER_GID=999 docker compose -f docker-compose-internal.yml configresolves with both keys on thespeckle-serverservice.