New encrypted wallet file header:#10339
Draft
ecdsa wants to merge 6 commits into
Draft
Conversation
ecdsa
commented
Dec 2, 2025
ecdsa
commented
Member
- the file is encrypted with a master key
- the master key is encrypted with one or several passwords
- passwords can be added to or removed from the list
- a hmac of the file is written at the beginning of the file
- passwords can be checked/updated without having to read/write the whole file
- the GUI assumes a single password
- partial writes: encrypted blobs are appended at the end of the file each blob is prefixed by its length can recover from incomplete write: hmac is updated after appending
ecdsa
force-pushed
the
new_file_headers
branch
2 times, most recently
from
ac622ca to
63d679e
Compare
Member
|
related #5999 |
ecdsa
force-pushed
the
new_file_headers
branch
from
63d679e to
90a99e4
Compare
- WalletDB no longer inherits from JsonDB, it uses a StoredDict - JsonDB inherits from BaseDB - FileStorage is only seen by JsonDB - calling JSonDB constructor creates the storage note: this commit temporarily breaks DB upgrades
this restores DB upgrades. (DB upgrades require not converting stored classes)
Add unit test of atomicity. Use a write batch for DB upgrades.
ecdsa
force-pushed
the
new_file_headers
branch
9 times, most recently
from
29c770b to
b2ce981
Compare
- the file is encrypted with a master key
- the master key is encrypted with one or several passwords
- passwords can be added to or removed from the list
- a hmac of the file is written at the beginning of the file
- passwords can be checked/updated without having to read/write the whole file
- the GUI assumes a single password
- partial writes:
encrypted blobs are appended at the end of the file
each blob is prefixed by its length
can recover from incomplete write: hmac is updated after appending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.