Skip to content

spinnaker kubectl install instructions to allow copy paste - #640

Open
aleon1220 wants to merge 3 commits into
spinnaker:masterfrom
aleon1220:feat/install-instructions-copy-paste
Open

spinnaker kubectl install instructions to allow copy paste#640
aleon1220 wants to merge 3 commits into
spinnaker:masterfrom
aleon1220:feat/install-instructions-copy-paste

Conversation

@aleon1220

Copy link
Copy Markdown
Contributor
  • use linux commands that any user can copy and paste
  • i defined a $WORKING_DIR to refer throughout the doc
  • makes the installation a copy and paste set of actions

* use linux commands that any user can copy and paste

```bash
mkdir -pv "$HOME/workspace-spinnaker-install/"
WORKING_DIR="$HOME/workspace-spinnaker-install"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOMINALLY "export WORKING_DIR" but not ENTIRELY required. NOTE: ... the "mkdir -pv" is equivalent to the fully named parameters below.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing

3. clone the base example github repo

```bash
git clone https://github.com/spinnaker/spinnaker.git $HOME/workspace-spinnaker-install/spinnaker

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be the primary fix - removing that spinnaker endpoint here as youd' get redundant folders. I think this is really the only piece of this PR that's needed. WORKING_DIR reduces the "$HOME/workspace-spinnaker-install" reuse everywhere, but that should be minor.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added WORKING_DIR

@aleon1220

Copy link
Copy Markdown
Contributor Author

@jasonmcintosh done. I also updated some packages in the package.json i hope is alright. Can be skipped no issue.

        "autoprefixer": "^10.5.4",
        "exec-bin": "^1.0.0",
        "hugo-installer": "^4.0.1",
        "postcss": "^8.4.31",
        "postcss-cli": "^11.0.1",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants