[Draft] Add explicit Noah role provisioning - dual format (list, dict) - #929
Open
patrykw-splunk wants to merge 5 commits into
Open
[Draft] Add explicit Noah role provisioning - dual format (list, dict)#929patrykw-splunk wants to merge 5 commits into
patrykw-splunk wants to merge 5 commits into
Conversation
…tasks The Noah pre_auth.yml was hardcoded to dict-format access (splunk.conf.server.content.noahService). This fails when splunk.conf is a list (the operator's native ConfFileEntry format). Fix: detect whether splunk.conf is a mapping or list and extract the noahService stanza accordingly. Apply the same dual-format pattern to the CSPL-4006 SSL replication port checks in indexer_clustering.yml and setup_multisite.yml. The existing dict2items fallback in main.yml is preserved for backward compatibility with users passing splunk.conf as a dict. Changes: - pre_auth.yml: two set_fact branches (dict vs list) for noah_service_stanza - indexer_clustering.yml: dual-format extraction for SSL replication check - setup_multisite.yml: same for multisite - test_noah_role_configuration.py: assert both format branches exist
refactor: standardize splunk.conf on native list format (remove dict-format access)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.