Skip to content

fix: reconcile_config_map_values unconditionally removes+reapplies every option #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tod-uma wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: reconcile_config_map_values unconditionally removes+reapplies every option #932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion roles/splunk_common/tasks/remove_config_map_stanza.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,10 @@
with_dict: "{{ config_map_stanza_settings }}"
loop_control:
loop_var: config_map_stanza_setting
when: config_map_stanza_name and config_map_stanza_settings
when:
- config_map_stanza_name and config_map_stanza_settings
# Only prune options no longer present in the current desired stanza. Options that are
# still desired (even with a changed value) are left for set_config_stanza.yml's
# idempotent `ini_file state=present` to update in place -- removing them here first
# made every option look changed on every run, even when its value hadn't moved.
- config_map_stanza_setting.key not in (conf_stanzas[config_map_stanza_name] | default({}))