-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support Git-style searchPaths with wildcards in AWS S3 buckets (#2812) #2958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomy8964
wants to merge
10
commits into
spring-cloud:main
Choose a base branch
from
tomy8964:feature/gh-2812-aws-s3-searchpaths
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
643060f
Support Git-style searchPaths with wildcards in AWS S3 buckets (#2812)
tomy8964 4a2c386
Merge branch 'main' into feature/gh-2812-aws-s3-searchpaths
tomy8964 daa088a
Refactor S3 env repo path/profile handling (#2812)
tomy8964 9546357
Merge branch 'spring-cloud:main' into feature/gh-2812-aws-s3-searchpaths
tomy8964 2d7d2d4
Use separate ConfigServerProperties in test (#2812)
tomy8964 5b2ac69
Potential fix for pull request finding
tomy8964 d17d727
Refactor S3 search paths and negated profiles (spring-cloud#2812)
tomy8964 17bbc58
Merge branch 'spring-cloud:main' into feature/gh-2812-aws-s3-searchpaths
tomy8964 f7c5afd
refactor: consolidate key-based S3ConfigFile classes and remove redun…
tomy8964 0568977
docs: add SearchPaths S3 DOCS
tomy8964 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be Collections.emptyList()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we initialized searchPaths using Collections.emptyList() to optimize memory usage and guarantee immutability by default.