feat: add TrimUI PyUI media and fn settings by vigstudio · Pull Request #1565 · spruceUI/spruceOS

vigstudio · 2026-07-02T10:04:46Z

Why

TrimUI Smart Pro/S users need PyUI-native access to stock-like video playback and Fn/DIP switch settings without falling back to the stock TrimUI UI. The stock CPU scene scripts also fail under spruceOS because CPU sysfs controls are locked and some stock frequencies are invalid on Smart Pro S, so Fn slider CPU performance mode does not apply reliably.

What Changed

Added PyUI Video Player browse, search, and controls screens backed by the existing MEDIA launcher.
Added PyUI Fn Key Settings for stock TrimUI DIP switch scene actions and joystick mode.
Added English and Vietnamese strings for the new PyUI screens.
Added Video Player and Fn editor icons, and made built-in app icons prefer app-folder icons.
Updated backlight Fn script to write the device backlight directly and persist brightness in /mnt/UDISK/system.json.
Added Smart Pro S CPU performance/save scene scripts that unlock and re-lock CPU sysfs controls and use valid CPU4 frequencies.
Updated buttons_watchdog.sh to poll GPIO363 for Fn slider/DIP changes, run scene scripts, and stop prior scene script instances before starting new ones.

Verification

Ran git diff --check successfully.
Ran python -m py_compile for trimui_fn_settings_app.py, video_player_app.py, and app_menu.py successfully.
On TrimUI Smart Pro S over SSH, toggled the physical Fn slider and verified /tmp/buttons_watchdog_dip.log recorded state 1 and state 0 transitions.
Verified CPU4 changes to performance 1992000 1992000 for performance state and returns to ondemand 1008000 1992000 for normal state.

Expose fn_editor for Smart Pro family devices and mirror Smart Pro display color settings with safe sysfs fallbacks on Smart Pro S.

Launch the firmware TinaPlayer via /usr/trimui/apps/player from PyUI Apps, and drop the mistaken display calibration changes on Smart Pro S.

Replace stock firmware app launches with themed PyUI menus: video browser plus ffplay playback, and Smart Pro Fn or switch toggles. Hide the legacy VideoPlayer wrapper and keep stock fneditor on Brick only.

Lazy-import Video Player and Fn settings in app_menu, and defer MiyooTrimCommon import until playback.

chrisj951 · 2026-07-06T21:13:21Z

                brightness_up
            fi
        ;;
+        *"key $B_L3 1"*) # Left Fn key down


Does the fn-key have the same keycode as L3/R3?

Even if it does this should be slightly refactored to

Have a new export for fn-key instead of reusing l3/r3

Make a call to fn_key_down/fn_key_up

in device.sh just make empty fn_key_down/up methods like all the others in there

move the run_fn_config into SmartProS.sh and this call into fn_key_down/up methods from (3)

chrisj951 · 2026-07-06T21:15:22Z

-                    return ControllerInput.R1
-
-
+


Are most of the line changes just line ending?

chrisj951 · 2026-07-06T21:17:23Z

+    ".mp4", ".mkv", ".avi", ".mov", ".flv", ".ts", ".webm",
+    ".m4v", ".wmv", ".mpeg", ".mpg", ".3gp",
+}
+VIDEO_ROOT = "/mnt/SDCARD/Roms/MEDIA"


Please update these to go through py-ui-config.json (located in App/PyUI/py-ui-config.json) and loaded through PyUiConfig.py

…ui-stock-settings # Conflicts: # App/PyUI/lang/English.json # App/PyUI/lang/Vietnamese.json # App/PyUI/main-ui/menus/app/app_menu.py

vigstudio · 2026-07-08T05:19:43Z

Updated branch vigstudio:feature/trimui-stock-settings.

Changes addressed:

Merged current upstream/Development and resolved conflicts in English.json, Vietnamese.json, and app_menu.py.
Reduced app_menu.py conflict to functional app additions while keeping upstream i18n descriptions.
Moved video root path into App/PyUI/py-ui-config.json and PyUiConfig.get_video_root_path().
Added device-level fn_key_down / fn_key_up hooks, SmartProS-specific Fn handling, and separate B_FN_LEFT / B_FN_RIGHT exports instead of using B_L3 / B_R3 directly in buttons_watchdog.sh.

Validation run:

python -m json.tool App/PyUI/lang/English.json
python -m json.tool App/PyUI/lang/Vietnamese.json
python -m json.tool App/PyUI/py-ui-config.json
python -m py_compile App/PyUI/main-ui/menus/app/app_menu.py App/PyUI/main-ui/menus/apps/video_player_app.py App/PyUI/main-ui/menus/apps/trimui_fn_settings_app.py App/PyUI/main-ui/utils/py_ui_config.py
bash -n spruce/scripts/buttons_watchdog.sh spruce/scripts/platform/device.sh spruce/scripts/platform/device_functions/SmartProS.sh App/fn_editor/com.trimui.cpuperformance.sh App/fn_editor/com.trimui.cpusave.sh App/fn_editor/com.trimui.switch.backlight.sh

Note: git diff --check still reports trailing whitespace from the upstream/Development i18n merge content; I left it untouched to avoid a broad whitespace-only cleanup in this PR.

vigstudio · 2026-07-08T06:03:35Z

Created duplicate PyUI-only PR for MainPyUI:
chrisj951/MainPyUI#91

Resolve conflicts by keeping videoRootPath config, adopting upstream spruce-native backlight Fn script, and retaining Brick/BrickPro fn_editor device list.

vigstudio · 2026-07-30T08:00:30Z

Updated vigstudio:feature/trimui-stock-settings against current upstream/Development.

Merge

Merged latest upstream/Development (includes screensaver, SmartProS button settings, Brick/BrickPro fn work).
Resolved conflicts in:
- App/PyUI/py-ui-config.json — kept both videoRootPath and screensaverTimeoutSec
- App/PyUI/main-ui/utils/py_ui_config.py — kept get_video_root_path()
- App/fn_editor/com.trimui.switch.backlight.sh — adopted upstream spruce-native set_backlight path
- App/fn_editor/config.json — kept Brick + BrickPro device list from upstream

Review feedback status (still in place)

Fn keys use B_FN_LEFT / B_FN_RIGHT + fn_key_down / fn_key_up hooks (SmartProS-specific).
Video root goes through py-ui-config.json / PyUiConfig.get_video_root_path().
app_menu.py remains a focused functional diff for the new apps.

Validation

python -m json.tool App/PyUI/py-ui-config.json
python -m py_compile for py_ui_config.py, app_menu.py, video_player_app.py, trimui_fn_settings_app.py
bash -n for buttons_watchdog.sh, device.sh, SmartProS.sh, com.trimui.switch.backlight.sh

vigstudio added 5 commits July 2, 2026 11:37

Enable TrimUI Fn editor and video calibration on Smart Pro S.

49259c3

Expose fn_editor for Smart Pro family devices and mirror Smart Pro display color settings with safe sysfs fallbacks on Smart Pro S.

Add TrimUI stock Video Player app for Smart Pro family.

3dd58c9

Launch the firmware TinaPlayer via /usr/trimui/apps/player from PyUI Apps, and drop the mistaken display calibration changes on Smart Pro S.

Add PyUI-native Video Player and Fn settings for TrimUI Smart Pro.

3922ec3

Replace stock firmware app launches with themed PyUI menus: video browser plus ffplay playback, and Smart Pro Fn or switch toggles. Hide the legacy VideoPlayer wrapper and keep stock fneditor on Brick only.

Fix PyUI boot circular import from native TrimUI apps.

afd37f2

Lazy-import Video Player and Fn settings in app_menu, and defer MiyooTrimCommon import until playback.

feat: add TrimUI PyUI media and fn settings

61632b5

vigstudio marked this pull request as ready for review July 2, 2026 10:05

feat: add TrimUI diagnostics and video index

7d237f8

chrisj951 reviewed Jul 6, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/Development' into feature/trim…

7e4a90c

…ui-stock-settings # Conflicts: # App/PyUI/lang/English.json # App/PyUI/lang/Vietnamese.json # App/PyUI/main-ui/menus/app/app_menu.py

vigstudio added 2 commits July 8, 2026 12:27

Reduce app menu diff noise

357ad46

Fix TrimUI language merge encoding

58b950f

vigstudio mentioned this pull request Jul 8, 2026

Add TrimUI PyUI media and Fn settings chrisj951/MainPyUI#91

Merged

Merge upstream/Development into feature/trimui-stock-settings.

8980516

Resolve conflicts by keeping videoRootPath config, adopting upstream spruce-native backlight Fn script, and retaining Brick/BrickPro fn_editor device list.

Navigation Menu

Uh oh!

feat: add TrimUI PyUI media and fn settings - #1565

feat: add TrimUI PyUI media and fn settings#1565
vigstudio wants to merge 10 commits into
spruceUI:Developmentfrom
vigstudio:feature/trimui-stock-settings

vigstudio commented Jul 2, 2026

Uh oh!

chrisj951 Jul 6, 2026

Uh oh!

chrisj951 Jul 6, 2026

Uh oh!

chrisj951 Jul 6, 2026

Uh oh!

vigstudio commented Jul 8, 2026 •

edited

Loading

Uh oh!

vigstudio commented Jul 8, 2026

Uh oh!

vigstudio commented Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vigstudio commented Jul 2, 2026

Why

What Changed

Verification

Uh oh!

chrisj951 Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

chrisj951 Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

chrisj951 Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

vigstudio commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vigstudio commented Jul 8, 2026

Uh oh!

vigstudio commented Jul 30, 2026

Merge

Review feedback status (still in place)

Validation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vigstudio commented Jul 8, 2026 •

edited

Loading