fix(mpc): reject invalid raw grid limits - #903
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
On the old base, a negative fuse and negative, NaN or infinite export limits reached planning after clamp logic turned them into disabled or fuse-only limits. The Service tests then published a new plan. The Go-DP repro also replaced the prior plan for a NaN export limit.
After this change:
go vet ./internal/mpcpassesmake verify-allpasses, including 134 Python tests, all Go tests, optimizer contracts, full stack, migration checks, vet, builds and linux/arm64, linux/amd64 and windows/amd64 cross-buildsScope
This PR hardens the MPC Service boundary only. Config and dispatch still need their own finite/range checks, but open PRs currently own those files. The changeset does not claim end-to-end config or hardware enforcement.
Part of #885.