fix(optimizer): skip converged PH iterations - #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ph_iterations: 0for that path;Root cause
The optimizer calculated the initial residual, but checked it only after one augmented PH iteration. A one-scenario plan has no non-anticipativity conflict, so its residual is already zero. The extra solve could hit
USER_LIMITand discard a valid plan.Measured before the fix, the one-scenario repro made two solver calls and returned
internal_errorwithUSER_LIMITin 5 of 5 runs. After the fix it makes one solver call, reports zero iterations and returns a replay-valid plan.Checks
make verify-allpassed, including Go tests, Core to optimizer contracts, vet, builds and release-target cross-builds;