Fix: Detail Page Default Tab Rendering#7074
Merged
WithoutPants merged 1 commit intoJun 26, 2026
Merged
Conversation
WithoutPants
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes detail page tab rendering when the route tab is missing or set to
default.The shared detail tab hook now resolves a render-safe
activeTabKeybefore renderingTabs, treating missing tab values and the internaldefaultsentinel as the populated default tab. Performer, group, studio, and tag detail pages now use that resolved key for tab activation and panel queries.This removes the per-page workaround that hid tabs until the URL effect ran, and also covers group detail pages and
/defaultURLs.Related Issue
Fixes #6798
Supercedes #6923
Also resolves the "Performer galleries not shown if performer has no scenes" bug in the bug tracker project board I believe
Testing
pnpm.cmd run checkpnpm.cmd run lint:jspnpm.cmd exec biome lint src/components/Shared/DetailsPage/Tabs.tsx src/components/Performers/PerformerDetails/Performer.tsx src/components/Groups/GroupDetails/Group.tsx src/components/Studios/StudioDetails/Studio.tsx src/components/Tags/TagDetails/Tag.tsxpnpm.cmd exec biome format src/components/Shared/DetailsPage/Tabs.tsx src/components/Performers/PerformerDetails/Performer.tsx src/components/Groups/GroupDetails/Group.tsx src/components/Studios/StudioDetails/Studio.tsx src/components/Tags/TagDetails/Tag.tsxgit diff --check/[type]/[id],/[type]/[id]/default, and/[type]/[id]/testfor performers, groups, studios, and tags for both when the first tab was populated and when the default tab populated was not the first.Screenshots
N/A
Checklist
AI Usage Disclosure
Used Codex to investigate the tab routing issue, draft the shared
activeTabKeyhandling, and then manually reviewed and tested the changes.Additional Context
The
defaulttab value is accepted by several detail routes but does not correspond to a renderedTab. Resolving it before render prevents React-Bootstrap from receiving an undefined or non-rendered active key, while the URL is still canonicalized afterward withhistory.replace.