Skip to content

Catch InvalidVersion in setup.py to fall back to source build #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chessing234 wants to merge 1 commit into from
Closed

Catch InvalidVersion in setup.py to fall back to source build #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import re
import ast
from pathlib import Path
from packaging.version import parse, Version
from packaging.version import parse, InvalidVersion, Version
import platform
import shutil

Expand Down Expand Up @@ -337,7 +337,11 @@ def run(self):
if FORCE_BUILD:
return super().run()

wheel_url, wheel_filename = get_wheel_url()
try:
wheel_url, wheel_filename = get_wheel_url()
except InvalidVersion:
print("Could not determine wheel URL (non-PEP 440 version). Building from source...")
return super().run()
print("Guessing wheel URL: ", wheel_url)
try:
urllib.request.urlretrieve(wheel_url, wheel_filename)
Expand Down