Skip to content

Fix compilation warnings #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheharyarn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compilation warnings #290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f034f9a
Fix compilation errors
sheharyarn Oct 28, 2019
c1d29f8
Address feedback
sheharyarn Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/arc/storage/s3.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ defmodule Arc.Storage.S3 do
destination_dir = definition.storage_dir(version, {file, scope})
s3_bucket = s3_bucket(definition)
s3_key = Path.join(destination_dir, file.file_name)
asset_host = asset_host(definition)
_asset_host = asset_host(definition)
Comment thread
sheharyarn marked this conversation as resolved.
Outdated
acl = definition.acl(version, {file, scope})

s3_options =
Expand Down
4 changes: 2 additions & 2 deletions lib/mix/tasks/g.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ defmodule Mix.Tasks.Arc do
end

defp generate_uploader_file(model_name, project_module_name, path) do
model_destination = Path.join(System.cwd(), "#{path}/#{underscore(model_name)}.ex")
model_destination = Path.join(File.cwd(), "#{path}/#{underscore(model_name)}.ex")
Comment thread
sheharyarn marked this conversation as resolved.
Outdated
create_uploader(model_name, project_module_name, model_destination)
end

defp generate_phx_uploader_file(model_name, project_module_name) do
app_name = Mix.Project.config[:app]
model_destination = Path.join(System.cwd(), "/lib/#{app_name}_web/uploaders/#{underscore(model_name)}.ex")
model_destination = Path.join(File.cwd(), "/lib/#{app_name}_web/uploaders/#{underscore(model_name)}.ex")
create_uploader(model_name, project_module_name, model_destination)
end

Expand Down