fix: drop dead sidebar links, allow https images in CSP - #327
Merged
Conversation
The smt.steem.io, jobs.lever.co/steemit and steemeconomy.com destinations are no longer maintained. Remove the three external links, their URL constants and the unused i18n keys (en/zh/es).
Avatars from steemitimages.com and user-controlled profile_image / cover_image URLs (arbitrary hosts, from chain metadata) were blocked by img-src 'self'. A host allowlist can never cover user URLs, so follow legacy (helmet imgSrc '*' data:') and allow any https: image; plain http is still upgraded by upgrade-insecure-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes in one PR:
Side panel cleanup — remove SMT Whitepaper / Jobs / Steem Business Center links. The destinations (smt.steem.io, jobs.lever.co/steemit, steemeconomy.com) are no longer maintained. Also removes the unused URL constants and i18n keys (en/zh/es).
CSP img-src fix — avatars (
steemitimages.com/u/<user>/avatar) and user-controlledprofile_image/cover_imageURLs from on-chain metadata were blocked byimg-src 'self' blob: data:. Since profile image hosts are arbitrary and cannot be allowlisted by name, follow legacy (helmet imgSrc: "* data:") and allow anyhttps:image. Plain http is still upgraded byupgrade-insecure-requests.Verified:
pnpm type-check, side-panel-links and proxy-csp unit tests (5 cases incl. a new img-src assertion).