fix(ui): stop header shifting when side panel opens - #328
Merged
Conversation
Radix's scroll lock hides the scrollbar and compensates with body padding-right, which only applies to in-flow elements. The header was position: fixed (viewport-relative), so it ignored the compensation and jumped sideways on every sheet/dialog open. Switch to sticky (same as condenser's Header) and drop the pt-16 spacer on <main> that only existed to clear the fixed header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the right side panel (or any Radix dialog) hides the page scrollbar and compensates with
padding-righton<body>. That compensation only applies to in-flow elements — the header wasposition: fixed(viewport-relative), so it ignored the padding and visibly jumped sideways on every open/close.Fix: switch the header to
sticky top-0(same approach as condenser's Header) so it participates in the body compensation, and drop thept-16spacer on<main>that only existed to clear the fixed header.Verified:
pnpm type-check+ all 528 unit tests pass; no other code depends on the fixed offset.