SPIKE: Protocol 28 (CAP-0084)#5961
Draft
sisuresh wants to merge 3 commits into
Draft
Conversation
…ndling Bump stellar-xdr to 7b56181 (Protocol 28 / CAP-0084) with XDR_FEATURES=CAP_0083,CAP_0084_MUXED_CONTRACT. Regen adds the SC_ADDRESS_TYPE_MUXED_CONTRACT arm to the ScAddress union. Update the exhaustive hand-written ScAddress switches in xdr/scval.go (String/Equals) to handle the muxed-contract arm so they no longer error/panic. SDK event parsing (extractAddress, parseBalanceChangeEvent) returns the underlying base contract address for muxed-contract destinations; surfacing the muxed id is deferred to horizon.
Commit 51284c1 bumped the .x sources to 787382e but did not fully regenerate gxdr/. Rerunning go generate picks up the corrected SorobanTransactionMetaExtV1.RentFeeCharged doc comment (totalNonRefundableResourceFeeCharged -> totalRefundableResourceFeeCharged), fixing the `check` (gogenerate diff) CI job. Comment-only; no behavior change.
This was referenced Jul 3, 2026
Contributor
Author
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates Go XDR for CAP-0084 (Muxed Contract Addresses).
Changes
XDR_COMMITpinned to stellar-xdr#307 head787382ef2099cca168ca1cb282730d6b7b9e2f16;XDR_FEATURES += CAP_0084_MUXED_CONTRACT.ScAddressTypeScAddressTypeMuxedContract,MuxedContractstruct, SCAddress arm).Deferred
Upstream
Downstream Rust anchor: SPIKE: Protocol 28 (CAP-0084) rs-stellar-xdr#552