Fix another expiration_ledger => live_until_ledger - #2847
Open
leighmcculloch wants to merge 2 commits into
Open
Conversation
Contributor
Contributor
|
PR Preview: torn down |
leighmcculloch
changed the title
leighmcculloch
marked this pull request as ready for review
September 11, 2026 20:27
leighmcculloch
requested review from
ElliotFriend
and
a balanced review from Copilot
September 11, 2026 20:27
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the storage-strategy diagram to match SEP-41 terminology.
Changes:
- Renames
expiration_ledgertolive_until_ledger.
Recommendation: MERGE-READY — correct and consistent with SEP-41.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the storage-strategies diagram with the live_until_ledger term instead of expiration_ledger.
Why
Alignment with SEP-41.
Related