Repository navigation
Match the Hello World page to current stellar contract init output - #2893
Merged
ElliotFriend merged 1 commit intoOct 6, 2026
Merged
Conversation
Contributor
Author
|
Friendly follow-up on this PR — happy to adjust anything (scope, approach, or details) if it helps review. Thanks for your time! |
stellar-cli 28.1.0 creates contracts/hello-world (the --name default), adds AGENTS.md, pins soroban-sdk "28" and sets crate-type to ["lib", "cdylib"]. Update the tree, file titles, Cargo.toml snippets and the crate-type sentence to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
theluckystrike
force-pushed
the
docs/hello-world-init-output
branch
from
October 6, 2026 15:42
52c2aef to
6316580
Compare
ElliotFriend
approved these changes
Oct 6, 2026
ElliotFriend
left a comment
ElliotFriend
left a comment
Contributor
There was a problem hiding this comment.
these are some great catches! thanks for the contribution, @theluckystrike!!
Contributor
|
PR Preview: torn down |
|
where do you deposit my àsséts for me to accept thém to spend
…On Tue, Oct 6, 2026, 8:50 AM Elliot Voris ***@***.***> wrote:
Merged #2893 <#2893> into
main.
—
Reply to this email directly, view it on GitHub
<#2893?email_source=notifications&email_token=A5LQRFIYLRBBFX4NOL6OWCT5SUIEXA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMRWGE2TCMJUGI3TRJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-32615114278>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5LQRFOZ5S3OIVOKMNRKGZD5SUIEXAVCNFSNUABFKJSXA33TNF2G64TZHM2TEMJTGA3TOMRZHNEXG43VMU5TKNRYHA3DINZWG432C5QC>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
you hàvé to ßéñy fúnds tó a bank in order for me to àccess thém
…On Tue, Oct 6, 2026, 10:58 AM gre3n3yes34 ***@***.***> wrote:
where do you deposit my àsséts for me to accept thém to spend
On Tue, Oct 6, 2026, 8:50 AM Elliot Voris ***@***.***>
wrote:
> Merged #2893 <#2893> into
> main.
>
> —
> Reply to this email directly, view it on GitHub
> <#2893?email_source=notifications&email_token=A5LQRFIYLRBBFX4NOL6OWCT5SUIEXA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMRWGE2TCMJUGI3TRJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-32615114278>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A5LQRFOZ5S3OIVOKMNRKGZD5SUIEXAVCNFSNUABFKJSXA33TNF2G64TZHM2TEMJTGA3TOMRZHNEXG43VMU5TKNRYHA3DINZWG432C5QC>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
|
só what bank ís associated with my withdrawal process
…On Tue, Oct 6, 2026, 10:58 AM gre3n3yes34 ***@***.***> wrote:
*gre3n3yes34* left a comment (stellar/stellar-docs#2893)
<#2893 (comment)>
where do you deposit my àsséts for me to accept thém to spend
On Tue, Oct 6, 2026, 8:50 AM Elliot Voris ***@***.***> wrote:
> Merged #2893 <#2893> into
> main.
>
> —
> Reply to this email directly, view it on GitHub
> <
#2893?email_source=notifications&email_token=A5LQRFIYLRBBFX4NOL6OWCT5SUIEXA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMRWGE2TCMJUGI3TRJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-32615114278>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/A5LQRFOZ5S3OIVOKMNRKGZD5SUIEXAVCNFSNUABFKJSXA33TNF2G64TZHM2TEMJTGA3TOMRZHNEXG43VMU5TKNRYHA3DINZWG432C5QC>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#2893?email_source=notifications&email_token=A5LQRFLJLV4QHKLC744O6V35SUXF7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBSGIZDQMZUG4YKM4TFMFZW63VNPFXXK4S7MFRXI2LWNF2HTJLFOZSW45FMMZXW65DFOJPWG3DJMNVQ#issuecomment-6022283470>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5LQRFINIIB2BTP37ZA33NT5SUXF7AVCNFSNUABFKJSXA33TNF2G64TZHM2TEMJTGA3TOMRZHNEXG43VMU5TKNRYHA3DINZWG432C5QC>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I'm located near à Bank for éàsy pick up
…On Tue, Oct 6, 2026, 11:01 AM gre3n3yes34 ***@***.***> wrote:
*gre3n3yes34* left a comment (stellar/stellar-docs#2893)
<#2893 (comment)>
só what bank ís associated with my withdrawal process
On Tue, Oct 6, 2026, 10:58 AM gre3n3yes34 ***@***.***> wrote:
> *gre3n3yes34* left a comment (stellar/stellar-docs#2893)
> <
#2893 (comment)>
> where do you deposit my àsséts for me to accept thém to spend
>
> On Tue, Oct 6, 2026, 8:50 AM Elliot Voris ***@***.***> wrote:
>
> > Merged #2893 <#2893> into
> > main.
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <
>
#2893?email_source=notifications&email_token=A5LQRFIYLRBBFX4NOL6OWCT5SUIEXA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMRWGE2TCMJUGI3TRJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-32615114278>,
>
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/A5LQRFOZ5S3OIVOKMNRKGZD5SUIEXAVCNFSNUABFKJSXA33TNF2G64TZHM2TEMJTGA3TOMRZHNEXG43VMU5TKNRYHA3DINZWG432C5QC>
>
> > .
> > You are receiving this because you are subscribed to this
thread.Message
> > ID: ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <
#2893?email_source=notifications&email_token=A5LQRFLJLV4QHKLC744O6V35SUXF7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBSGIZDQMZUG4YKM4TFMFZW63VNPFXXK4S7MFRXI2LWNF2HTJLFOZSW45FMMZXW65DFOJPWG3DJMNVQ#issuecomment-6022283470>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/A5LQRFINIIB2BTP37ZA33NT5SUXF7AVCNFSNUABFKJSXA33TNF2G64TZHM2TEMJTGA3TOMRZHNEXG43VMU5TKNRYHA3DINZWG432C5QC>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#2893?email_source=notifications&email_token=A5LQRFODJ2V6P2BGGPNU3JL5SUXRNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBSGIZTGNBZHEY2M4TFMFZW63VNPFXXK4S7MFRXI2LWNF2HTJLFOZSW45FMMZXW65DFOJPWG3DJMNVQ#issuecomment-6022334991>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5LQRFKJH26EU65GEWCUJWL5SUXRNAVCNFSNUABFKJSXA33TNF2G64TZHM2TEMJTGA3TOMRZHNEXG43VMU5TKNRYHA3DINZWG432C5QC>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hello World page shows a project layout that
stellar contract initno longer creates. I ranstellar contract init soroban-hello-worldwith stellar-cli 28.1.0 and compared the output with the page.What the CLI creates today:
Changes on the page:
contracts/hello-world, notcontracts/hello_world. The--namedefault ininit.rsis"hello-world", and the directory uses the name as is. I updated the tree, the prose and the four file titles. Thehello_world.wasmoutput path stays, since Cargo turns the dash into an underscore.Cargo.lock, whichinitdoes not create, and missedAGENTS.md.Cargo.tomlpinssoroban-sdk = "28", not"26".Cargo.tomlhascrate-type = ["lib", "cdylib"]. That changed in contract init: generate a contract that's compatible with fuzzing stellar-cli#1814 so fuzz targets can import the contract. I added one sentence on whylibis there, with a link to the fuzzing guide.Prettier check passes on the file. No URLs change.