Skip to content

Document how to host stellar.toml for testnet and mainnet - #2896

Open
kaankacar wants to merge 4 commits into
mainfrom
2870-stellar-toml-per-network
Open

kaankacar wants to merge 4 commits into
mainfrom
2870-stellar-toml-per-network

Conversation

@kaankacar

Copy link
Copy Markdown
Contributor

Asset issuers asked how to run separate testnet and mainnet stellar.toml files when a domain has only one /.well-known/stellar.toml.

Changes:

  • docs/platforms/anchor-platform/sep-guide/sep1/README.mdx: new section "Testnet and mainnet files". It explains that discovery follows an account's home_domain, when a testnet file is needed, the one-host-per-network pattern, what differs per network, and how to test discovery before mainnet. The old production-vs-development admonition now points to it.
  • docs/tokens/publishing-asset-info.mdx: short "Testnet and mainnet" note that links to the new section.

Facts checked against SEP-1, the Demo Wallet README, and the live file at testanchor.stellar.org.

Closes #2870

A domain serves one stellar.toml and that file describes one network.
Add a section to the SEP-1 guide that explains how discovery follows an
account's home_domain, when a testnet file is needed, the one-host-per-
network pattern, what differs per network, and how to test discovery
before mainnet. Link to it from the asset publishing page.

Closes #2870
Copilot AI lite review requested due to automatic review settings October 6, 2026 13:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved documentation accuracy and executable-example issues remain.

Review effort: Lite
Findings: 1 High severity · 2 Medium severity

Open (3)
What changed in this PR

Documents how issuers can host and validate separate SEP-1 stellar.toml files for testnet and mainnet.

Changes:

  • Adds network-specific hosting and discovery guidance.
  • Adds testnet validation steps.
  • Links the guidance from asset publishing documentation.
File Summary
docs/​platforms/​anchor-platform/​sep-guide/​sep1/​README.mdx Adds testnet/mainnet hosting and testing guidance.
docs/​tokens/​publishing-asset-info.mdx Links issuers to the new guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/platforms/anchor-platform/sep-guide/sep1/README.mdx Outdated
Comment thread docs/platforms/anchor-platform/sep-guide/sep1/README.mdx Outdated
Comment thread docs/platforms/anchor-platform/sep-guide/sep1/README.mdx Outdated
@github-actions github-actions Bot added the preview Preview builds for PRs by SDF employees. label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Discovery follows the issuing account's home_domain, so drop the
distribution account from the text. Make the admonition conditional,
because a testnet file is only needed when another party must discover
the testnet deployment. Use a GET request for the CORS check, because
some servers add the header only to GET responses.
Copilot AI lite review requested due to automatic review settings October 6, 2026 13:49
@github-actions github-actions Bot removed the preview Preview builds for PRs by SDF employees. label Oct 6, 2026
@github-actions github-actions Bot added the preview Preview builds for PRs by SDF employees. label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Unresolved documentation inaccuracies and ambiguities remain.

Review effort: Lite
Findings: None

Resolved since last review (3)
Previously missed (3)

In code that hasn't changed since last review

Medium severity Clarify whether Stellar Lab requires testnet stellar.toml discovery

docs/​platforms/​anchor-platform/​sep-guide/​sep1/​README.mdx:57

The linked issue explicitly asks whether Stellar Lab needs a testnet stellar.toml, but this section only covers wallets, the Demo Wallet, and direct endpoint tests. Lab is a transaction/API tool rather than a SEP-1 discovery client, so state that explicitly; otherwise issuers still cannot tell whether using Lab alone requires a second host.

Medium severity Distinguish ACCOUNTS from the SEP-10 signing key

docs/​platforms/​anchor-platform/​sep-guide/​sep1/​README.mdx:75

SIGNING_KEY is the public key derived from the deployment's SECRET_SEP10_SIGNING_SEED, not necessarily an account; the SEP-10 guide describes it as a key used to sign challenges (docs/platforms/anchor-platform/sep-guide/sep10/README.mdx:47-53). Saying that the ACCOUNTS and SIGNING_KEY values are different accounts can lead issuers to configure the wrong value. Distinguish the network-specific account list from the network-specific SEP-10 signing key.

Medium severity Replace shell-unsafe account placeholder in curl command

docs/​platforms/​anchor-platform/​sep-guide/​sep1/​README.mdx:97

<ACCOUNT_ID> is parsed by the shell as redirection syntax, so copying this command literally does not request the intended account URL. Use a shell-safe placeholder such as YOUR_ACCOUNT_ID (and quote the URL if desired) so the documented check can actually run.

Say that Stellar Lab does not read stellar.toml, so Lab alone needs no
testnet file. Separate the ACCOUNTS list from the SEP-10 SIGNING_KEY,
which is the public key of the signing seed, not an account. Replace
the angle-bracket placeholder in the curl command, which the shell
parses as a redirect.
@kaankacar

Copy link
Copy Markdown
Contributor Author

Addressed Copilot's three suppressed notes in b042aaa:

  • Stellar Lab: added that Lab does not read stellar.toml, so Lab alone needs no testnet file. The Lab source has no stellar.toml fetch.
  • SIGNING_KEY: now its own bullet, described as the public key of the SEP-10 signing seed, separate from ACCOUNTS.
  • curl placeholder: <ACCOUNT_ID> is now YOUR_ACCOUNT_ID, so the command runs as written.

Copilot AI lite review requested due to automatic review settings October 6, 2026 14:08
@github-actions github-actions Bot removed the preview Preview builds for PRs by SDF employees. label Oct 6, 2026
@github-actions github-actions Bot added the preview Preview builds for PRs by SDF employees. label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Clarify keypair wording, ORG_URL requirements, and when a separate testnet file is needed.

Review effort: Lite
Findings: 1 Low severity

Open (1)

Comment thread docs/platforms/anchor-platform/sep-guide/sep1/README.mdx Outdated
The same public key can exist on testnet and mainnet. Describe ACCOUNTS
and CURRENCIES issuer addresses as the values for each deployment, and
say that separate keys are common but not required.
Copilot AI lite review requested due to automatic review settings October 6, 2026 14:47
@github-actions github-actions Bot removed the preview Preview builds for PRs by SDF employees. label Oct 6, 2026
@github-actions github-actions Bot added the preview Preview builds for PRs by SDF employees. label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Only minor documentation nits remain; no blocking issues were identified.

Review effort: Lite
Findings: None

Resolved since last review (1)

@kaankacar
kaankacar requested a review from ElliotFriend October 6, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Preview builds for PRs by SDF employees.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document how to host stellar.toml for separate testnet and mainnet environments

2 participants