Repository navigation
Conversation
Two startup behaviors were missing from the backfill section. With an empty database, RPC starts at the latest ledger in the history archive, so a larger HISTORY_RETENTION_WINDOW alone adds no older ledgers. BACKFILL requires a gapless local database and stops startup with "db verify: gap detected in local DB" otherwise. Both checked against stellar-rpc v28.0.1 and v29.0.0. Closes #2602
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The only review comment is a minor documentation nit; no blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Documents RPC startup behavior for empty databases and BACKFILL gap validation.
Changes:
- Clarifies fresh-start ingestion and retention behavior.
- Documents the gapless-database prerequisite and startup error.
| File | Description |
|---|---|
docs/data/apis/rpc/admin-guide/configuring.mdx |
Adds fresh-start and gap-check guidance for BACKFILL. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2789, which documented the
BACKFILLflag. Two startup behaviors were still missing from the "Backfilling History on Startup" section. Both are checked against stellar-rpc v29.0.0 and v28.0.1:HISTORY_RETENTION_WINDOWalone does not add older ledgers. Source:cmd/stellar-rpc/internal/ingest/service.go,getNextLedgerSequence, theErrEmptyDBcase.BACKFILLrequires a local database with no ledger-sequence gaps.RunBackfillcallsverifyDbGaplessfirst, and a gap stops startup withdb verify: gap detected in local DB. Source:cmd/stellar-rpc/internal/ingest/backfill.go.@Shaptic, could you confirm the two statements? Elliot asked for an RPC-team check on the startup caveats in #2602.
Closes #2602