Skip to content

fix(templates): correct doc link and clean up issue/PR templates#256

Merged
mehtarac merged 1 commit into
strands-agents:mainfrom
yonib05:fix/issue-pr-templates
Jun 11, 2026
Merged

fix(templates): correct doc link and clean up issue/PR templates#256
mehtarac merged 1 commit into
strands-agents:mainfrom
yonib05:fix/issue-pr-templates

Conversation

@yonib05

@yonib05 yonib05 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the broken documentation link and tidies the issue/PR templates.

Changes

  • config.yml — the documentation contact link pointed at github.com/strands-agents/docs. Updated to the Evals quickstart (https://strandsagents.com/docs/user-guide/evals-sdk/quickstart/) and added a Discussions support link (Discussions is enabled on this repo).
  • bug_report.yml / feature_request.yml — removed the hardcoded type label (bug / enhancement). Blank issues are disabled, so users sometimes file through the wrong form, which baked in the wrong type. The issue-labeler classifies type from the issue content, so it handles this more reliably. Kept triage and added python (Evals is Python-only).
  • bug_report.yml — fixed "lastest" typo and dropped the binary install-method option (Evals ships via pip only).
  • PR template — removed the stale consuming repositories: agents-docs, agents-tools, agents-cli line (copied from another repo; not applicable here) and fixed the "agent-docs repo" reference.

Notes

  • The triage label did not exist on the repo and has been created (the templates referenced it but it was never present).

Testing

  • Open a new issue via each template and confirm the contact links resolve and labels apply as expected.

- config.yml: fix the documentation link (was github.com/strands-agents/docs)
  to the evals quickstart, and add a Discussions support link.
- bug_report.yml / feature_request.yml: drop the hardcoded type label
  (bug/enhancement). Blank issues are disabled, so people sometimes file
  through the wrong form; the issue-labeler classifies type from content
  more reliably. Keep triage, add python since evals is Python-only.
- bug_report.yml: fix "lastest" typo and drop the binary install option
  (evals ships via pip only).
- PR template: remove the stale "consuming repositories: agents-docs,
  agents-tools, agents-cli" reference that does not apply to evals.
@github-actions

Copy link
Copy Markdown

Assessment: Comment (approve once the labeler question is resolved)

This is a clean, low-risk, config-only cleanup. I verified the new doc link (strandsagents.com/docs/user-guide/evals-sdk/quickstart/) resolves (HTTP 200), Discussions is enabled on the repo so that contact link is valid, and both triage and python labels exist. The lastestlatest typo fix, binary install-method removal, and PR-template cleanup are all correct.

Review themes
  • Label automation assumption (Important): The rationale for dropping bug/enhancement depends on an "issue-labeler" that I can't find in .github/workflows/. Without it, new issues get no type label. Worth confirming where that automation lives.
  • Docs/label consistency (Important): CONTRIBUTING.md links filter issues by label:bug / label:enhancement; those views won't populate for new issues if the labels aren't applied.
  • python label semantics (Suggestion): Its description is PR-oriented; applying to issues is slightly off and possibly redundant for a Python-only repo.

Nice tidy-up of templates that had clearly drifted from another repo — the doc link and consuming-repos fixes are real improvements.

@yonib05

yonib05 commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

Thanks — the labeler concern is valid but already resolved: the issue-labeler workflow is introduced in companion PR #255 (.github/workflows/issue-labeler.yml), which classifies and applies the bug/enhancement/etc. type labels from issue content. This PR drops the hardcoded template type labels precisely because that automation handles it more reliably (people sometimes file through the wrong form since blank issues are disabled).

Merge order matters: #255 should merge before (or together with) this one, so there's no window where new issues get no type label. The CONTRIBUTING.md label:bug / label:enhancement filter links you flagged will populate correctly once #255 is in.

On the python label semantics — fair point that its description is PR-oriented. Since evals is Python-only, applying it to issues is intentional (a cheap, always-correct language signal), but I'm open to tightening the label description in a follow-up if it reads oddly.

@mehtarac mehtarac merged commit f41cf4e into strands-agents:main Jun 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants