fix: return text message for empty search results in file_read#488
Open
xlyoung wants to merge 1 commit into
Open
fix: return text message for empty search results in file_read#488xlyoung wants to merge 1 commit into
xlyoung wants to merge 1 commit into
Conversation
Fixes strands-agents#303 When file_read in search mode found no matching results, it returned an empty content list [] which caused downstream Bedrock API errors. Now it returns a helpful text message indicating no search results were found, while maintaining status: 'success'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #303
When
file_readin search mode finds no matching results, it previously returned an empty content list{"content": []}, which caused downstream Bedrock API errors.Changes
src/strands_tools/file_read.py: Added a check for empty search results in thesearchmode code path. When no results are found, it now returns a helpful text message (No search results found for pattern '<pattern>' in <file_path>) instead of an empty content list, while maintainingstatus: "success".tests/test_file_read.py: Addedtest_file_read_tool_direct_search_no_resultstest to verify the fix.Testing
All 19 existing tests pass, including the new test:
Before
{"toolUseId": "...", "status": "success", "content": []}After
{"toolUseId": "...", "status": "success", "content": [{"text": "No search results found for pattern 'xyz' in /path/to/file.txt"}]}