fix: make get_html truncation configurable instead of hard-coded#490
Open
xlyoung wants to merge 1 commit into
Open
fix: make get_html truncation configurable instead of hard-coded#490xlyoung wants to merge 1 commit into
xlyoung wants to merge 1 commit into
Conversation
The get_html action had a hard-coded 1,000-character truncation limit that returned broken HTML fragments (mid-tag). This was problematic because: 1. 1,000 characters is too small for most real-world HTML content 2. Truncating at a character boundary breaks HTML structure 3. Users had no way to control or disable the truncation Changes: - Add optional `max_length` parameter to GetHtmlAction model - Only truncate when max_length is explicitly set by the user - Default is None (no truncation, return full content) - Truncation message now includes "...[truncated]" indicator Fixes strands-agents#407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
get_htmlbrowser action had a hard-coded 1,000-character truncation limit that returned broken HTML fragments:This caused issues because:
Fix
max_lengthparameter toGetHtmlActionmodelmax_lengthis explicitly set by the userNone(no truncation, return full content)"...[truncated]"indicator for clarityBefore
After
Testing
Existing tests pass. The browser tests require
bedrock_agentcorewhich is not available in the test environment (pre-existing issue).Fixes #407