Skip to content

fix: prevent shell tool hang with pager-based commands in non-interactive mode #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xlyoung wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix: prevent shell tool hang with pager-based commands in non-interactive mode #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/strands_tools/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,16 @@ def execute_with_pty(self, command: str, cwd: str, non_interactive_mode: bool) -

if pid == 0: # Child process
try:
# Ensure TERM is set for proper terminal emulation
os.environ.setdefault("TERM", "xterm-256color")

# Disable pagers in non-interactive mode to prevent hangs
# (e.g. git diff spawning 'less' which waits for input)
if non_interactive_mode:
os.environ.setdefault("GIT_PAGER", "cat")
os.environ.setdefault("PAGER", "cat")
os.environ.setdefault("MANPAGER", "cat")

os.chdir(cwd)
os.execvp("/bin/sh", ["/bin/sh", "-c", command])
except Exception as e:
Expand Down
Loading