fix(assert): fail Never when condition does not return before timeout#1901
Open
leno23 wants to merge 1 commit into
Open
fix(assert): fail Never when condition does not return before timeout#1901leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Track whether the condition completed at least once. If waitFor elapses before the first evaluation returns, report a failure instead of passing without checking. Fixes stretchr#1654
leno23
force-pushed
the
fix/never-timeout-before-condition-returns-1654
branch
from
3bdb1c4 to
2f881ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Never's condition completed at least once beforewaitForelapsesFixes #1654
Problem
If the condition blocks longer than
waitFor,Nevercould return success without ever observing the condition result.Test plan
go test ./assert -run TestNeverTestNeverTimeoutBeforeConditionReturnsmatching the issue reproducer