Add amneziawg cable driver to using= flags#2492
Open
sanek9 wants to merge 1 commit into
Open
Conversation
sanek9
requested review from
Oats87,
mkolesnik,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
July 23, 2026 23:32
|
🤖 Created branch: z_pr2492/sanek9/feat/amneziawg-cable-driver |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe Makefile ChangesAmneziaWG driver selection
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Map using=amneziawg to CABLE_DRIVER for E2E/deploy. Userspace driver needs no host kernel module. Signed-off-by: sanek9 <sanya0996@gmail.com>
sanek9
force-pushed
the
feat/amneziawg-cable-driver
branch
from
July 24, 2026 00:02
d94e78f to
6536b35
Compare
2 tasks
skitt
approved these changes
Jul 24, 2026
skitt
enabled auto-merge (rebase)
July 24, 2026 07:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
using=amneziawgtoCABLE_DRIVER=amneziawginMakefile.incso Shipyard deploy/E2E can select the AmneziaWG cable driver.Context
Companion to submariner-io/submariner#4097, which adds
amneziawgto the Submariner CI E2E / flake-finder cable-driver matrix. Those jobs useshipyard/gh-actions/e2e@devel, so this change needs to land on Shipyarddevelfor the matrix entries to select AmneziaWG correctly (otherwiseCABLE_DRIVERstays at the libreswan default).Test plan
make deploy using=amneziawg(or E2E) setsCABLE_DRIVER=amneziawg/ passes--cable-driver amneziawgto subctlusing=wireguardstill installs modules and setsCABLE_DRIVER=wireguard)Made with Cursor
Summary by CodeRabbit