http: add Secure flag to TXID cookie#447
Open
TanayK07 wants to merge 1 commit into
Open
Conversation
The __txid cookie was being set without the Secure flag, allowing it to be transmitted over unencrypted connections. Since LiteFS typically runs behind a TLS-terminating reverse proxy, default SecureCookie to true so the cookie is only sent over HTTPS. A "secure-cookie" option is added to the proxy YAML config so that users running local development without TLS can explicitly disable it. Fixes superfly#440
Author
|
hey @benbjohnson sorry to bug you, any chance of a quick look at this one? its a small security fix (12 lines) for the missing Secure flag on the __txid cookie, fixes #440. we run litefs at work so happy to adjust if anything needs changeing. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The __txid cookie was being set without the Secure flag, allowing it to be transmitted over unencrypted connections. Since LiteFS typically runs behind a TLS-terminating reverse proxy, default SecureCookie to true so the cookie is only sent over HTTPS.
A "secure-cookie" option is added to the proxy YAML config so that users running local development without TLS can explicitly disable it.
Fixes #440