-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(tweet-preview): guard JSON.parse to avoid crashing the modal #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ishaanxgupta
merged 5 commits into
supermemoryai:main
from
vimzh:fix/tweet-preview-guard-json-parse
Jun 2, 2026
+100
−4
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e5ead50
fix(tweet-preview): guard JSON.parse to avoid crashing on malformed t…
vimzh 0944e5f
fix(tweet-preview): reject array inputs in parseTweetData
vimzh 3fe7eb8
fix(tweet-preview): shape-check, fallback UI, memoize, and warn on ba…
vimzh e7684c1
fix(tweet-preview): tighten Tweet shape check to fields enrichTweet r…
vimzh 162e1d3
fix(tweet-preview): default entity arrays and guard enrichTweet
vimzh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.