fix: page through all list results instead of relying on Page: -1 - #178
Open
ghaering wants to merge 1 commit into
Open
fix: page through all list results instead of relying on Page: -1#178ghaering wants to merge 1 commit into
ghaering wants to merge 1 commit into
Conversation
Page: -1 does not return everything. The SDK sends page=0&limit=0 and Forgejo answers with just the default first page (~30 items), so listing and then searching by name or id missed anything past page 1. Walk the pages instead. Same as the team fix, applied to the remaining list-then-search data sources and the action secret resources.
Member
|
Hi @ghaering, many thanks for your interest in the provider, and thank you very much for your valuable contribution! I had been experimenting with the pagination feature (#119) but couldn't really get anywhere, since the API / SDK never returned anything past the first page. That's why we ended up switching to ID-based lookups for organizations, in order to avoid the pagination misbehavior altogether. Have you tested that the API / SDK pagination now fully works for all objects? Which version of Forgejo is that? Please include acceptance tests to verify if we can actually retrieve items past the first page. |
acch
added
bug
acch
requested changes
Aug 5, 2026
acch
left a comment
acch
left a comment
Member
There was a problem hiding this comment.
Please include acceptance tests to verify if we can actually retrieve items past the first page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page: -1 does not return everything. The SDK sends page=0&limit=0 and Forgejo answers with just the default first page (~30 items), so listing and then searching by name or id missed anything past page 1.
Walk the pages instead. Same as the team fix, applied to the remaining list-then-search data sources and the action secret resources.