Skip to content

fix(team): Make permission and units_map mutually exclusive. - #186

Draft
kad-hollac1 wants to merge 1 commit into
svalabs:mainfrom
kadaster:fix/team/permissions
Draft

fix(team): Make permission and units_map mutually exclusive.#186
kad-hollac1 wants to merge 1 commit into
svalabs:mainfrom
kadaster:fix/team/permissions

Conversation

@kad-hollac1

Copy link
Copy Markdown
Contributor

Fixes: #149.

@kad-hollac1
kad-hollac1 requested a review from acch as a code owner August 12, 2026 14:20
@kad-hollac1
kad-hollac1 marked this pull request as draft August 12, 2026 14:20
@kad-hollac1
kad-hollac1 force-pushed the fix/team/permissions branch from 2c50d11 to b6caf94 Compare August 12, 2026 18:09
@kad-hollac1
kad-hollac1 force-pushed the fix/team/permissions branch from b6caf94 to 10e3eb4 Compare August 13, 2026 18:39
@kad-hollac1

Copy link
Copy Markdown
Contributor Author

Meh, we're hitting [0]. So we can go two routes from here:

  1. Update the SDK to not require a permission.
  2. Calculate the required permission ourselves, based on [1].

I'd go for 1., but that means quite a delay.

[0] https://codeberg.org/mvdkleijn/forgejo-sdk/src/branch/main/forgejo/org_team.go#L149
[1] https://codeberg.org/forgejo/forgejo/src/branch/forgejo/models/unit/unit.go#L426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

forgejo_team: Refactor permission & units_map attributes

1 participant