Skip to content

chore(bindings): upgrade sourcemap and getrandom#10486

Closed
Brooooooklyn wants to merge 1 commit into
mainfrom
upgrade-deps
Closed

chore(bindings): upgrade sourcemap and getrandom#10486
Brooooooklyn wants to merge 1 commit into
mainfrom
upgrade-deps

Conversation

@Brooooooklyn

@Brooooooklyn Brooooooklyn commented May 20, 2025

Copy link
Copy Markdown
Member

@Brooooooklyn Brooooooklyn requested review from a team as code owners May 20, 2025 02:44
@changeset-bot

changeset-bot Bot commented May 20, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9a85b14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Brooooooklyn Brooooooklyn marked this pull request as draft May 20, 2025 03:22
@kdy1

kdy1 commented May 20, 2025

Copy link
Copy Markdown
Member

Is this required to fix error "ARM assembler must define __ARM_ARCH?

@kdy1 kdy1 added this to the Planned milestone May 20, 2025
@Brooooooklyn

Copy link
Copy Markdown
Member Author

error "ARM assembler must define __ARM_ARCH

This has been fixed, this is fix for upgrading getrandom, getrandom has significant breaking changes and is widely depended upon. Upgrading getrandom helps reduce compilation errors for users of swc.

@kdy1

kdy1 commented May 21, 2025

Copy link
Copy Markdown
Member

Can you take a look at https://github.com/swc-project/swc/actions/runs/15146697538/job/42584398787? It's still happening. Is it caused by 2212d3d ?

@codspeed-hq

codspeed-hq Bot commented Jul 9, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #10486 will not alter performance

Comparing upgrade-deps (9a85b14) with main (883b24c)

Summary

✅ 152 untouched benchmarks

@kdy1

kdy1 commented Jul 10, 2025

Copy link
Copy Markdown
Member

Closing as both crates are up-to-date

@kdy1 kdy1 closed this Jul 10, 2025
@kdy1 kdy1 deleted the upgrade-deps branch July 10, 2025 17:29
@kdy1 kdy1 modified the milestones: Planned, v1.12.12 Jul 13, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants