Skip to content

Recognize actor (distributed) methods and extensions as Async functions #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktoso merged 11 commits into from
Aug 21, 2026
Merged

Recognize actor (distributed) methods and extensions as Async functions #895

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eb3337d
Recognize Actor methods and methods in extensions as `implicitly asyn…
AbdAlRahmanGad Aug 19, 2026
af8fd89
Recognize actor methods as Async functions in JNI translation
AbdAlRahmanGad Aug 19, 2026
3929e4a
Apply swift format
AbdAlRahmanGad Aug 19, 2026
4ebd90b
Guard `isImplicitlyAsync` from static and class methods and initializers
AbdAlRahmanGad Aug 19, 2026
65202e4
Recognise nonisolated methods
AbdAlRahmanGad Aug 20, 2026
1c42f1e
Recognise `@concurrent` as non isolated func
AbdAlRahmanGad Aug 20, 2026
6df12eb
Handle `@concurrent` inside actors
AbdAlRahmanGad Aug 20, 2026
3c3bd02
Add runtime tests
AbdAlRahmanGad Aug 20, 2026
eeb0c37
Throw lowering error in `FFM` mode
AbdAlRahmanGad Aug 20, 2026
e1c5463
Recognize `distributed` methods as throwing
AbdAlRahmanGad Aug 20, 2026
059552f
Add runtime test for `Distributed` methods
AbdAlRahmanGad Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/SwiftExtract/SwiftTypes/SwiftFunctionSignature.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ public struct SwiftFunctionSignature: Equatable {
}

public var isImplicitlyAsync: Bool {
!isAsync && selfParameter?.selfType.isActor == true
guard !isAsync, case .instance(_, let selfType) = selfParameter else {
Comment thread
AbdAlRahmanGad marked this conversation as resolved.
Outdated
return false
}
return selfType.isActor
}

public var isThrowing: Bool {
Expand Down
1 change: 0 additions & 1 deletion Tests/SwiftExtractTests/AnalysisResultTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,6 @@ struct AnalysisResultSuite {
#expect(count.isClass)
}


// ==== -----------------------------------------------------------------------
// MARK: Actor members are extracted
@Test func actorMembersAreExtracted() throws {
Expand Down
Loading