Repository navigation
Conversation
The launcher patches the game by reading the suspended 32-bit ffxivgame.exe thread context (GetThreadContext), which a 64-bit process cannot do, so a 64-bit Windows launcher can't patch or launch the game. Standardize Windows on the 32-bit i686-pc-windows-msvc target everywhere: - src/lib.rs: compile_error! rejecting x86_64-pc-windows-msvc so a non-functional 64-bit binary can never be built or shipped. Inert on macOS/Linux and on the i686 target. - ci.yml: the Windows leg builds + tests --target i686-pc-windows-msvc (macOS/Linux build their native host via a per-OS matrix target). - release-binaries.yml: Windows artifact is now i686-pc-windows-msvc. - Both workflows install NASM on the Windows runner: aws-lc-sys (via librqbit -> aws-lc-rs for torrent-piece SHA-1) assembles its crypto with NASM, and the 32-bit target has no prebuilt objects. - scripts/package-windows.cmd: 32-bit only (dropped the --target override). Local `cargo build` / `cargo run` default to 32-bit via a per-machine, gitignored .cargo/config.toml pinning build.target = i686-pc-windows-msvc; a committed pin can't be used because Cargo config is not host-conditional and would force i686 on macOS/Linux checkouts. Documented in dev-environment.md, CLAUDE.md, and AGENTS.md. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher patches the game by reading the suspended 32-bit ffxivgame.exe thread context (GetThreadContext), which a 64-bit process cannot do, so a 64-bit Windows launcher can't patch or launch the game. Standardize Windows on the 32-bit i686-pc-windows-msvc target everywhere:
Local
cargo build/cargo rundefault to 32-bit via a per-machine, gitignored .cargo/config.toml pinning build.target = i686-pc-windows-msvc; a committed pin can't be used because Cargo config is not host-conditional and would force i686 on macOS/Linux checkouts. Documented in dev-environment.md, CLAUDE.md, and AGENTS.md.