Skip to content

fix: add GPT-5.6 to Codex OAuth models #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boorluck wants to merge 1 commit into
base: main
Choose a base branch
from
+41 −13
Open

fix: add GPT-5.6 to Codex OAuth models #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions backend/cli/src/provider/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,31 @@ import { ProviderTransform } from "./transform"
export namespace Provider {
const log = Log.create({ service: "provider" })

const CODEX_MODEL_IDS = new Set<string>([
"gpt-5.6",
"gpt-5-6",
"gpt-5.6-sol",
"gpt-5-6-sol",
"gpt-5.6-terra",
"gpt-5-6-terra",
"gpt-5.6-luna",
"gpt-5-6-luna",
"gpt-5.5",
"gpt-5-5",
"gpt-5.4",
"gpt-5-4",
"gpt-5.4-mini",
"gpt-5-4-mini",
"gpt-5.3-codex",
"gpt-5-3-codex",
"gpt-5.2",
"gpt-5-2",
])

export function isCodexModel(modelID: string): boolean {
return CODEX_MODEL_IDS.has(modelID)
}

function isGpt5OrLater(modelID: string): boolean {
const match = /^gpt-(\d+)/.exec(modelID)
if (!match) {
Expand Down Expand Up @@ -1095,22 +1120,10 @@ export namespace Provider {
// snapshot normalizes dots to dashes (e.g. `gpt-5-5`) while the
// OpenAI API expects dots (`gpt-5.5`). We pick up whichever the
// snapshot ships and route it through the codex provider.
const codexModelIds = new Set<string>([
"gpt-5.5",
"gpt-5-5",
"gpt-5.4",
"gpt-5-4",
"gpt-5.4-mini",
"gpt-5-4-mini",
"gpt-5.3-codex",
"gpt-5-3-codex",
"gpt-5.2",
"gpt-5-2",
])
const baseOpenai = database["openai"]
const codexModels: Record<string, (typeof baseOpenai.models)[string]> = {}
for (const [id, model] of Object.entries(baseOpenai.models)) {
if (codexModelIds.has(id)) {
if (isCodexModel(id)) {
codexModels[id] = {
...model,
providerID: "openai-codex",
Expand Down
15 changes: 15 additions & 0 deletions backend/cli/test/provider/provider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,21 @@ import { Env } from "../../src/env"
const SONNET = "claude-sonnet-4-6"
const OPUS = "claude-opus-4-5"

test("Codex OAuth allowlist includes the GPT-5.6 family", () => {
for (const id of [
"gpt-5.6",
"gpt-5-6",
"gpt-5.6-sol",
"gpt-5-6-sol",
"gpt-5.6-terra",
"gpt-5-6-terra",
"gpt-5.6-luna",
"gpt-5-6-luna",
]) {
expect(Provider.isCodexModel(id)).toBe(true)
}
})

test("pinned catalog models are present in the seeded test fixture", async () => {
await using tmp = await tmpdir({})
await Instance.provide({
Expand Down