Repository navigation
fix: 日本語IMEの変換確定Enterでセッション名を誤確定しない - #82
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
日本語IMEでセッション名を変更する際、変換確定のEnterが名前変更の確定にも使われ、入力途中でダイアログが閉じていました。変換中と変換確定フレームではEnterによる確定とフォーカス解除を抑止し、変換後のEnterで名前を確定します。「変更」ボタンからの確定も維持します。
IME判定を同じ描画フレーム内で保持し、未確定文字列が空になる終了イベントや、EnterとCommitの到着順が異なる場合も保護します。
検証:
tools/verify.sh --lint rename_ime_tests e2e::ime_tests keybinds::: lint・警告チェック、関連テスト96件tools/windows-check.sh: Windows MSVC向けのテストコードを含むコンパイル検証未確認: 実際のWindows日本語IMEでのGUI操作。Linux検証はDocker未起動のため未実施。