Skip to content

ci: optimize PR workflows (ubuntu-slim, triage consolidation) - #3979

Merged
vasfvitor merged 6 commits into
v2from
improve-ci
Jul 20, 2026
Merged

vasfvitor merged 6 commits into
v2from
improve-ci

Conversation

@vasfvitor

@vasfvitor vasfvitor commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

to sum up I was annoyed with the long running ci and wanted to optmize, claude was quick on the trigger and opened a pr, I'm still reviewing, but changes were planned. There's one more think I'd like to maybe add and is astro-check

bonus point it found a bug

edit: it also got the changes from my other branch lol

here is the issue:
image

todo: bump action labeler


yada yada below:

TAURI_DOCS_SKIP_IMAGE_OPT=true to avoid sharp in preview

  • Concurrency cancel-in-progress, timeout-minutes: 30
  • pnpm check (astro check) runs as an informational step (continue-on-error: true) until the pre-existing type-error backlog is cleared.
  1. Light jobs → ubuntu-slim

  2. Automation consolidated into triage.yml
    assign.yml + labeler.yml + priority.yml + status.yml

fix: always-false .status == 'open' guard — the webhook field is .state, so project Status/Priority field-setting has never actually run until now (704f107).

this fix probably will mutate lots of issues/pr status

@netlify

netlify Bot commented Jul 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for tauri-v2 ready!

Name Link
🔨 Latest commit b33b802
🔍 Latest deploy log https://app.netlify.com/projects/tauri-v2/deploys/6a5e53a59217830008c0c6a1
😎 Deploy Preview https://deploy-preview-3979--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@socket-security

socket-security Bot commented Jul 18, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​astrojs/​check@​0.9.91001008086100

View full report

@socket-security

socket-security Bot commented Jul 18, 2026 •

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm @astrojs/compiler is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yaml → npm/@astrojs/check@0.9.9 → npm/@astrojs/compiler@2.13.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@astrojs/compiler@2.13.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm yargs is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yaml → npm/@astrojs/check@0.9.9 → npm/yargs@17.7.3

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/yargs@17.7.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@vasfvitor

vasfvitor commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor Author

dam claude is quick on the trigger

Comment thread .github/workflows/build.yml Outdated
@vasfvitor vasfvitor changed the title ci: optimize PR workflows (full-build gate, ubuntu-slim, triage consolidation) ci: optimize PR workflows (ubuntu-slim, triage consolidation) Jul 18, 2026
Comment thread .github/workflows/triage.yml Outdated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from merging them all together, I've made a few changes, I hope nothing breaks

Comment thread package.json
Comment on lines +54 to +57
},
"devDependencies": {
"@astrojs/check": "^0.9.9",
"typescript": "^5.9.3"

@vasfvitor vasfvitor Jul 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will bump to typescript 7 later. The security note is about astro-check, currently it is only used locally

@vasfvitor
vasfvitor marked this pull request as ready for review July 19, 2026 00:04
@vasfvitor
vasfvitor requested a review from a team as a code owner July 19, 2026 00:04

@FabianLars FabianLars left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added for Simon who's no longer active. Do we still need this? I never understood the value of it.

@FabianLars

Copy link
Copy Markdown
Member

I don't think the comment ended up where I wanted it to be. I hate this mobile app. I meant the auto assign pr author thing

@FabianLars

Copy link
Copy Markdown
Member

Similarly are we even using the project board?

@dreyfus92

Copy link
Copy Markdown
Member

we're not using the project board at all! so ig we can drop that workflow.

@vasfvitor

Copy link
Copy Markdown
Contributor Author

about the auto assign I feel the same. About the board, I'm also not using, thought about dropping this whole thing but then thought about giving it a try and see if it can be useful

@vasfvitor

Copy link
Copy Markdown
Contributor Author

I'll drop the workflow and revert the unrelated submoudle changes

@vasfvitor

Copy link
Copy Markdown
Contributor Author

removed auto assign, priority and status

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job @vasfvitor 👀

@vasfvitor
vasfvitor merged commit db73155 into v2 Jul 20, 2026
10 of 11 checks passed
@vasfvitor
vasfvitor deleted the improve-ci branch July 20, 2026 16:58
@github-project-automation github-project-automation Bot moved this from 🪵 Backlog to ✅ Done in Documentation Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants