Skip to content

Make changes based on PR #4 feedback: Clean Configuration Management, OOP, and Testing + Maybe stylistic changes #8

Description

@ilgaur

I'm following code review feedback from PR #4, trying to implement requested improvements.

Major:

  • Cleaner configuration management #9
  • Think about the tradeoffs of replacing subprocess calls with a Git library and abstract away those commands and maybe make it optional too
  • OOP restructuring
  • Unit tests

Minor:

  • Update .pre-commit-hooks.yaml to reference original remote repo URL
  • Add a .pre-commit-config.yaml or explain how to create and use it in the README
  • Add args and additional_dependencies explicitly to .pre-commit-config.yaml. (Envs is mentioned at the top on the major issues because it probably needs more work and is tied to other tasks)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions