Skip to content

Update container testing#4925

Open
LecrisUT wants to merge 5 commits into
teemtee:mainfrom
LecrisUT:f44-container
Open

Update container testing#4925
LecrisUT wants to merge 5 commits into
teemtee:mainfrom
LecrisUT:f44-container

Conversation

@LecrisUT
Copy link
Copy Markdown
Member

@LecrisUT LecrisUT commented May 27, 2026 •
edited
Loading

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Fedora 44 and Fedora 45 test container images, including their standard, upstream, and unprivileged variants, and updates the test image scripts accordingly. Feedback highlights the need to ensure Fedora 45 Containerfiles reference the correct base image version, add a trailing newline when appending to /etc/sudoers, and include a linter ignore comment for the upstream Containerfile.

Comment thread Makefile Outdated
Comment thread containers/fedora/44/Containerfile.unprivileged
Comment thread containers/fedora/44/Containerfile.upstream
@LecrisUT LecrisUT added the ci | full test Pull request is ready for the full test execution label May 29, 2026
@github-project-automation github-project-automation Bot moved this to backlog in planning May 29, 2026
@therazix therazix moved this from backlog to review in planning May 29, 2026
@happz
Copy link
Copy Markdown
Contributor

happz commented Jun 1, 2026

Some changes the PR does not mention at all: Fedora 42 containers dropped, Fedora 45 added.

@LecrisUT LecrisUT changed the title Add f44 container targets Update container testing Jun 1, 2026
@LecrisUT
Copy link
Copy Markdown
Member Author

LecrisUT commented Jun 1, 2026 •
edited
Loading

Some changes the PR does not mention at all: Fedora 42 containers dropped, Fedora 45 added.

Updated the description, it has evolved since it was opened. F45 target was not added, it's not in the test matrix (what you saw was addition to Makefile target only, removed that one to reduce confusion)

thrix
thrix reviewed Jun 1, 2026
View reviewed changes
Comment thread tests/images.sh
Comment on lines +106 to +109
function is_fedora_45 () {
is_fedora_rawhide "$1"
}

Copy link
Copy Markdown
Contributor

@thrix thrix Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a good idea, we will need to remember to update this after 45 branched?

Copy link
Copy Markdown
Member Author

@LecrisUT LecrisUT Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the current state of how the branching is handled/not handled. This is purely an improvement over the status quo

@psss psss added this to the 1.75 milestone Jun 2, 2026
@happz
Copy link
Copy Markdown
Contributor

happz commented Jun 3, 2026

Relevant tests are failing:

:: [ 09:47:58 ] :: [   INFO   ] :: rlWaitForCmd: waiting for `make -C /var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests/tests/.. images/test/tmt/container/test/fedora/42/bootc\:latest' to return 0 in 3600 seconds
make: Entering directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'
make: *** No rule to make target 'images/test/tmt/container/test/fedora/42/bootc:latest'.  Stop.
make: Leaving directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'
make: Entering directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'
make: *** No rule to make target 'images/test/tmt/container/test/fedora/42/bootc:latest'.  Stop.
make: Leaving directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'
make: Entering directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'
make: *** No rule to make target 'images/test/tmt/container/test/fedora/42/bootc:latest'.  Stop.
make: Leaving directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'
make: Entering directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'
make: *** No rule to make target 'images/test/tmt/container/test/fedora/42/bootc:latest'.  Stop.
make: Leaving directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'
make: Entering directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'
make: *** No rule to make target 'images/test/tmt/container/test/fedora/42/bootc:latest'.  Stop.
make: Leaving directory '/var/ARTIFACTS/work-execute97ye82dw/plans/provision/container/execute/discover/default-0/tests'

LecrisUT added 4 commits June 3, 2026 13:35
@LecrisUT
Update container targets
f6f4f94 
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT
Add f44 target
6d71fa5 
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT
Drop F42 targets
6ea9504 
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT
Simplify package manager test branching
95ae84e
@LecrisUT
Bring back make target
034a613 
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT
Copy link
Copy Markdown
Member Author

LecrisUT commented Jun 4, 2026 •
edited
Loading

/packit retest-failed

@packit-as-a-service

This comment was marked as outdated.

Sign in to view
@LecrisUT LecrisUT added the area | maintenance Changes important for efficiency and the long-term health of the project label Jun 5, 2026
@therazix therazix removed this from the 1.75 milestone Jun 5, 2026
@psss psss mentioned this pull request Jun 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thrix thrix thrix left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

area | maintenance Changes important for efficiency and the long-term health of the project ci | full test Pull request is ready for the full test execution

Projects

planning
Status: review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LecrisUT @happz @thrix @psss @therazix