Rename enable_repo/disable_repo package manager methods#4936
Open
happz wants to merge 4 commits into
Open
Conversation
happz
added
code | no functional change
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames enable_repo and disable_repo to enable_repository and disable_repository across various package manager classes. Rename the remaining enable_repo and disable_repo methods in PackageManager and its subclasses to complete the renaming and maintain consistency.
| self.guest.execute(self.engine.enable_repo(*repo_ids)) | ||
| self.guest.execute(self.engine.enable_repository(*repo_ids)) | ||
|
|
||
| def disable_repo(self, *repo_ids: str) -> None: |
Contributor
There was a problem hiding this comment.
I think this should be renamed as well?
LecrisUT
approved these changes
May 29, 2026
vaibhavdaren
previously approved these changes
Jun 3, 2026
We already have `install_repository`, `create_repository`, let's follow the full-name suite.
happz
force-pushed
the
rename-enable-disable-repo
branch
from
c6d12ef to
e39e699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have
install_repository,create_repository, let's follow the full-name suite.Pull Request Checklist