Skip to content

Refine koji artifact error handling #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LecrisUT wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −4
Open

Refine koji artifact error handling #4956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3b7c14
Narrow try catch scope
LecrisUT Jun 3, 2026
8cc823d
Ensure we have koji config file
LecrisUT Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packaging/rpm/tmt.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ metadata specification (L1 and L2) and allows easy test execution.
%pyproject_extras_subpkg -n tmt report-junit
%pyproject_extras_subpkg -n tmt report-polarion
%pyproject_extras_subpkg -n tmt link-jira
%pyproject_extras_subpkg -n tmt prepare-artifact

%package -n tmt+test-convert
Summary: Dependencies required for tmt test import and export
Expand Down Expand Up @@ -135,6 +134,14 @@ Requires: mock

%description -n tmt+provision-mock %_metapackage_description

%package -n tmt+prepare-artifact
Summary: Dependencies required for tmt prepare artifact
Requires: tmt == %{version}-%{release}
Requires: koji
Requires: python3-copr

%description -n tmt+prepare-artifact %_metapackage_description

# Replace with pyproject_extras_subpkg at some point
%package -n tmt+all
Summary: Extra dependencies for the Test Management Tool
Expand Down
6 changes: 3 additions & 3 deletions tmt/steps/prepare/artifact/providers/koji.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ def _initialize_session(
Also :py:attr:`_top_url` and :py:attr:`_api_url` being the base URL for the Koji instance.
"""
import_koji(self.logger)
config = koji.read_config("koji") # type: ignore[union-attr]
self._api_url = api_url or config.get("server")
self._top_url = top_url or config.get("topurl")

try:
config = koji.read_config("koji") # type: ignore[union-attr]
self._api_url = api_url or config.get("server")
self._top_url = top_url or config.get("topurl")
return ClientSession(self._api_url)
except Exception as error:
raise tmt.utils.GeneralError(
Expand Down
Loading