Adding --gcp-cloud-run-no-sync-quiet-ms flag - #1167
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37bae511f3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| at least 0; 0 disables the quiet window. If omitted, the version's | ||
| existing scaling settings are left unchanged. Only valid with | ||
| --gcp-cloud-run-worker-pool. |
There was a problem hiding this comment.
Remove the worker-pool co-requirement from this help
For update-version-compute-config, this says the new flag is only valid when --gcp-cloud-run-worker-pool is supplied, but the command's documented and implemented scaler-only mode accepts the five scaler flags without any provider flags and updates only scaler.details. A user following this option-level help may unnecessarily supply all required provider fields and overwrite the provider configuration rather than performing the intended scaler-only update.
Useful? React with 👍 / 👎.
Related issues
Closes: https://temporalio.atlassian.net/browse/COM-241
What changed?
Adds
--gcp-cloud-run-no-sync-quiet-mstotemporal worker deployment create-versionand
temporal worker deployment update-version-compute-config.Cloud Run scaler group, so
--gcp-cloud-run-min-instances,--gcp-cloud-run-max-instances,--gcp-cloud-run-initial-instances,--gcp-cloud-run-utilization-target, and--gcp-cloud-run-no-sync-quiet-msmust now all be set together.
no_sync_quiet_msconfig key,which WCI already validates and applies — no server-side change is required.
before it may scale the Cloud Run worker pool down. Raising it keeps the pool
from scaling down before long-running or bursty activities finish. Defaults to
90000 (90s) when unset; must be
>= 0(0 disables the quiet window).describe-versionnow surfaces the value (JSONnoSyncQuietMsand theone-line compute-config summary).
This is a stopgap for long/bursty activities pending GCP's configurable graceful
shutdown; it is not itself graceful shutdown.
Checklist
Stability
-o json/-o jsonl) are treated as breaking changes — see note 1Design
temporal <noun> <verb>structure — no new commands; flag added to existing commands(Experimental)incommands.yaml— see note 3Help text (see style guide at the top of
commands.yaml)--namespace, not-n), one flag per lineYourXxxform (YourWorkflowId,YourNamespace)Behavior
Tests
SharedServerSuite)func TestXxx) where applicableNotes for reviewer
describe-versiongains an additivenoSyncQuietMsfield. Thesurrounding GCP scaler config block is not in a tagged release yet, so no
released output changes — hence not marked 💥. Flag if you'd prefer otherwise.
no-sync-quiet-msmirrors the documentedno_sync_quiet_msscalerconfig key and matches the sibling
--gcp-cloud-run-*scaler knobs. It's atechnical tuning knob, so the name is the concept; happy to rename if you see
a friendlier fit.
(Experimental). It's a stable, functional knob, butit's positioned as a stopgap pending GCP graceful shutdown — mark it if the
team prefers signaling that.
Manual tests
Setup