You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
define portal proxies versus the shared ZONE_PORTAL_LOGIC_ADDRESS
require initialization through a portal proxy DELEGATECALL; direct logic-contract initialization reverts
specify the temporary ZonePortal deployment that produces constructor-specialized runtime code, then installs that runtime at the canonical logic address
retain factory-only, one-time initialization per portal proxy
Validation
git diff --check
Forge build remains blocked because GitHub source archives omit the tips/verify submodules
Hi @legion2002 — your review approval was detected by Voight-Kampff, but this repository configures allow-self-reviews: false, so the current head commit author cannot approve their own changes. Your review did not trigger an approval prompt and is not counted toward this PR.
Ask another reviewer to +1 the PR (or submit an "Approve" review) to satisfy the gate.
Hi @legion2002 — your review approval was detected by Voight-Kampff, but this repository configures allow-self-reviews: false, so the current head commit author cannot approve their own changes. Your review did not trigger an approval prompt and is not counted toward this PR.
Ask another reviewer to +1 the PR (or submit an "Approve" review) to satisfy the gate.
Hi @legion2002 — your review approval was detected by Voight-Kampff, but this repository configures allow-self-reviews: false, so the current head commit author cannot approve their own changes. Your review did not trigger an approval prompt and is not counted toward this PR.
Ask another reviewer to +1 the PR (or submit an "Approve" review) to satisfy the gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZONE_PORTAL_LOGIC_ADDRESSDELEGATECALL; direct logic-contract initialization revertsZonePortaldeployment that produces constructor-specialized runtime code, then installs that runtime at the canonical logic addressValidation
git diff --checktips/verifysubmodulesPrompted by: @0xalpharush