fix: align messenger with native factory ABI#700
Draft
legion2002 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
ZoneMessengerto decode the flattenedzones(uint32)return ABI exposed by the TIP-1091 native factory.The reference
IZoneFactory, Solidity factory, andSwapAndDepositRouteruse the same getter shape so the repository remains internally consistent. A focused regression test exercisesrelayMessage()against the flattened payload.This addresses tempoxyz/tempo#6874 (comment).
The bundled zone dev genesis is regenerated because the factory creation bytecode embeds the messenger creation bytecode.
Validation:
FOUNDRY_HARDFORK=cancun forge fmt --checkFOUNDRY_HARDFORK=cancun forge build --no-lintFOUNDRY_HARDFORK=cancun forge test --match-contract ZoneMessengerFactoryAbiTestcargo test -p zone-node zone_test_genesis_factory_bytecode_matches_foundry_artifact -- --nocapturegit diff --check